Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash Report #5208

Closed
BrianSchoenecker opened this issue Feb 15, 2025 · 14 comments
Closed

Crash Report #5208

BrianSchoenecker opened this issue Feb 15, 2025 · 14 comments

Comments

@BrianSchoenecker
Copy link

1 sequence out of 66 crashes during render. I added some props for this year. It ran fine last December.

xLights_dbgrpt-19088-20250215T170514.zip

@derwin12
Copy link
Collaborator

Perhaps a combination of layering and new video effect. Can you upload the videos? looks like perhaps a .mov file? If it is just this sequence, I wonder about the .mov format.

@BrianSchoenecker
Copy link
Author

BrianSchoenecker commented Feb 16, 2025

All I get is Failed to upload "Like It's Christmas.mov"

@derwin12
Copy link
Collaborator

You need to zip that first then assuming it is not too big, upload it. I wonder if the special characters in the name are killing something. (Shouldnt) .. can you remove the effect where that is used to see if it is indeed that file?

@BrianSchoenecker
Copy link
Author

Every video in the sequence is cautioned in yellow. "contains characters in the path or file name that will cause issues in xLights. Please rename it." The issue is the sequence worked fine 2 months ago. And none of the mp4s or the mov have odd characters. FPP didn't have an issue with it, either. I see I acquired it in 2021, so I hope I didn't pay much for it.

@BrianSchoenecker
Copy link
Author

I reverted back to 2024.20, and it rendered just fine. I'll stick with that version for now.

@derwin12
Copy link
Collaborator

The new code is in .03 and going forward. We cant fix it without some more pieces.

@BrianSchoenecker
Copy link
Author

I can't fix my problem with it crashing before I can fix it. If you DM me an email address in FB, I can send you the sequence video.

@derwin12
Copy link
Collaborator

Thread: 0000027960 Whole House Model - Rendering layer effect for frame 2803 of Whole House Model, layer 3: CHECKBOX_Palette2=1,CHECKBOX_Palette3=1,CHECKBOX_SynchroniseWithAudio=0,CHECKBOX_Video_AspectRatio=1,CHECKBOX_Video_TransparentBlack=0,CHOICE_BufferStyle=Per Preview,CHOICE_Video_DurationTreatment=Normal,FILEPICKERCTRL_Video_Filename=C:\Christmas Sequences 2021\Like It's Christmas\1080_Pop_Up_Trees_Red_Videvo.mov,TEXTCTRL_Duration=0:30.040,TEXTCTRL_Fadein=.5,TEXTCTRL_Fadeout=1,TEXTCTRL_Video_CropBottom=0,TEXTCTRL_Video_CropLeft=0,TEXTCTRL_Video_CropRight=100,TEXTCTRL_Video_CropTop=100,TEXTCTRL_Video_Speed=1.5,TEXTCTRL_Video_Starttime=0.00,TEXTCTRL_Video_TransparentBlack=0

@derwin12
Copy link
Collaborator

The double stack of this one video is causing the crash. If I remove one, its fine. So it could be a case of the new video + the layering code. Need to diagnose.
Here is link to stripped down .zip xsqz
https://drive.google.com/file/d/1Vk6KoIOdAktzl8aw5UCIEkOfsuzFM-Ij/view?usp=drive_link

@derwin12
Copy link
Collaborator

Just an update .. its not really the actual video that is the problem. The 2 layered effects ... the bottom is a full buffer, the top is only a small slice of the buffer. Something is happening on the clean up of that after the render causing the crash.

@BrianSchoenecker
Copy link
Author

BrianSchoenecker commented Feb 16, 2025 via email

@derwin12
Copy link
Collaborator

I got the bug addressed - Unrelated, but I noticed your layout as an old "issue". Your stars on the trees with layers. You need to go into the layers and change the layer sizes from small to large, inner to outer.

Image

@BrianSchoenecker
Copy link
Author

BrianSchoenecker commented Feb 17, 2025 via email

derwin12 added a commit to derwin12/xLights that referenced this issue Feb 18, 2025
keithsw1111 pushed a commit that referenced this issue Feb 18, 2025
* Address buffer overflow crash in video effect #5208

* Rounding error causing crash and skewed image #5208
@derwin12
Copy link
Collaborator

In next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants