Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused go-repl worker #370

Merged
merged 4 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,3 @@ issues:
- pkg/worker
- cmd/webworker
- web
exclude-rules:
- path: 'internal/gowasm/(.+)\.go'
linters:
- typecheck
1 change: 0 additions & 1 deletion HACKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ WASM Go programs are located in [`cmd/wasm`](./cmd/wasm/) directory.
| Package | Description |
| ---------- | --------------------------------------------------------------------------------------------------------------------------- |
| `analyzer` | Very simple Go syntax checker. |
| `go-repl` | Deprecated tool with [Yaegi](https://github.com/traefik/yaegi) Go interpreter. Used to run Go programs without compilation. |

### Tools & Scripts

Expand Down
6 changes: 1 addition & 5 deletions build.mk
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,8 @@ wasm_exec.js:
analyzer.wasm:
$(call build_wasm_worker,analyzer)

.PHONY:go-repl.wasm
go-repl.wasm:
$(call build_wasm_worker,go-repl)

.PHONY:wasm
wasm: wasm_exec.js analyzer.wasm go-repl.wasm
wasm: wasm_exec.js analyzer.wasm

.PHONY: build
build: check-go check-yarn clean preinstall gen collect-meta build-server wasm pkg-index build-ui
Expand Down
5 changes: 0 additions & 5 deletions build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ RUN echo "Building server with version $APP_VERSION" && \
-buildvcs=false \
-ldflags "-s -w" \
-trimpath \
-o ./go-repl@$WASM_API_VER.wasm ./cmd/wasm/go-repl && \
GOOS=js GOARCH=wasm go build \
-buildvcs=false \
-ldflags "-s -w" \
-trimpath \
-o ./analyzer@$WASM_API_VER.wasm ./cmd/wasm/analyzer && \
cp $(go env GOROOT)/misc/wasm/wasm_exec.js ./wasm_exec@v2.js && \
cp $(go env GOROOT)/misc/wasm/wasm_exec.js ./wasm_exec.js && \
Expand Down
5 changes: 0 additions & 5 deletions build/release.dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,6 @@ COPY go.sum .
## wasm_exec.js files are left for backwards compatibility for old clients.
RUN echo "Building server with version $APP_VERSION" && \
go build -o server -ldflags="-X 'main.Version=$APP_VERSION'" ./cmd/playground && \
GOOS=js GOARCH=wasm go build \
-buildvcs=false \
-ldflags "-s -w" \
-trimpath \
-o ./go-repl@$WASM_API_VER.wasm ./cmd/wasm/go-repl && \
GOOS=js GOARCH=wasm go build \
-buildvcs=false \
-ldflags "-s -w" \
Expand Down
37 changes: 0 additions & 37 deletions cmd/wasm/go-repl/main.go

This file was deleted.

27 changes: 0 additions & 27 deletions internal/gorepl/errors.go

This file was deleted.

148 changes: 0 additions & 148 deletions internal/gorepl/handler_js.go

This file was deleted.

Loading
Loading