-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ViewComponent to v3.9.0 #492
Bump ViewComponent to v3.9.0 #492
Conversation
✅ Deploy Preview for govuk-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This is in response to GHSA-wf2x-8w6j-qw37 My commit includes hacks to get the specs to pass to potentially save you some time, but I'm not sure it's the right way to actually fix the underlying breakages. Happy to take your steer or if to close the PR if you want to do it yourself. |
This addresses an XSS vector ViewComponent/view_component#1950
325eb3d
to
984cd31
Compare
I'm also seeing warnings in the RSpec run:
I dunno if they've been introduced by this bump? |
They have, just tracking them down now. |
Those warnings can be fixed with: diff --git a/app/components/govuk_component/tab_component.rb b/app/components/govuk_component/tab_component.rb
index 1ac03dd..8dc2250 100644
--- a/app/components/govuk_component/tab_component.rb
+++ b/app/components/govuk_component/tab_component.rb
@@ -23,7 +23,7 @@ private
def initialize(label:, text: nil, classes: [], html_attributes: {})
@label = label
- @text = text
+ @text = h(text)
super(classes: classes, html_attributes: html_attributes)
end Happy with the changes, once the above is in I'll get it merged and a release ready 🙂 Thanks @benilovj |
This silences the warning: WARNING: The GovukComponent::TabComponent::Tab component rendered HTML-unsafe output. The output will be automatically escaped, but you may want to investigate.
This addresses an XSS vector ViewComponent/view_component#1950