Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation design update #486

Merged
merged 9 commits into from
Dec 26, 2023
Merged

Documentation design update #486

merged 9 commits into from
Dec 26, 2023

Conversation

paulrobertlloyd
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd commented Dec 24, 2023

This PR does a few things, increasingly more ambitious/contentious!

  • Fixes the logo in the header now that we need to support the new v5 way of doing things
  • Removes the inverse styles that are no longer needed as supplied by v5
  • Uses the Masthead component styles from the GOVUK Prototype Components project
  • Adds a modifier class to the header on the index page to account for the masthead
  • Increases the overall width of the page container, and adds sub-navigation to all pages

Happy to break apart into separate PRs, but hopefully nothing in here is too contentious.

And if you’re happy with these changes, I’ll go off and do the same for the Form Builder docs. 🎁

Screenshot of Getting started page showing updated logo in the header and sub navigation with the current page selected.

@paulrobertlloyd paulrobertlloyd added the documentation Improvements or additions to documentation label Dec 24, 2023
Copy link

netlify bot commented Dec 24, 2023

Deploy Preview for govuk-components ready!

Name Link
🔨 Latest commit 12bfa05
🔍 Latest deploy log https://app.netlify.com/sites/govuk-components/deploys/658853df2298f50008927ffb
😎 Deploy Preview https://deploy-preview-486--govuk-components.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@peteryates
Copy link
Member

This looks amazing! Nothing contentious at all. I'll take a closer look soon but really happy to see this, early Christmas present 🎁

Copy link
Member

@peteryates peteryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, everything's super clear and the guide is so much easier to navigate now.

@paulrobertlloyd paulrobertlloyd added this pull request to the merge queue Dec 26, 2023
Merged via the queue into main with commit e1ab281 Dec 26, 2023
12 checks passed
@paulrobertlloyd paulrobertlloyd deleted the docs-design-update branch December 26, 2023 12:25
github-merge-queue bot pushed a commit that referenced this pull request Dec 28, 2023
Following on from #486, a few supplemental tweaks:

- Consolidate header styles (should have placed all the header styles
used for the guide in the same file; had I done initially I would have
seen a rule I should have removed)
- Consistent syntax and the navigation Slim templates, to hopefully be a
bit clearer
- Use the related navigation component styles from the GOVUK Prototype
Components project for related information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants