Configurable Note plugin #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and the user can convert from one class/data-type pair to another; if one of them does not support a title it is removed.
|
|
||
| # Find all classes that could mean something is "notish" | ||
| # so they can be removed when the type is changed from the dropdown. | ||
| notishClasses = {} | ||
|
|
||
| Plugin.create 'note', | ||
| init: () -> | ||
| # Load up specific classes to listen to or use the default | ||
| types = @settings.types or {note: true} |
There was a problem hiding this comment.
this default config should be updated, and possibly moved to a more intelligent place for a default config to live, does aloha have a standard for that?
|
@tmsp1 Aloha does have a way to define Plugin defaults; I updated the code and added documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the note plugin so it can listen to multiple classes or type attributes and switch between them in the dropdown.