Random welcome fix 1637 #1645
Random welcome fix 1637 #1645
Conversation
|
Fix worked. Welcome.ans file does not need to be in the /gfiles directory. just welcome.1 .2 .3 .4 etc.. |
Does this address #1644 ? |
| } | ||
| } | ||
| } | ||
| if (i) { |
There was a problem hiding this comment.
I bet these two can be collapsed somehow, also isn't this already in an "if (i)" block?
There was a problem hiding this comment.
in prior section of code, "i = 0" can make this next section not fire off.
| @@ -256,7 +256,8 @@ void Output::print_local_file(const std::string& data) { | |||
|
|
|||
| bool Output::printfile_random(const std::string& data) { | |||
| const printfile_opts opts(sess(), *this, data, true, true); | |||
| const auto& dir = sess().dirs().current_menu_gfiles_directory(); | |||
| // const auto& dir = sess().dirs().current_menu_gfiles_directory(); | |||
There was a problem hiding this comment.
you can nix this. currently printfile_random and printfile default to using gfiles/menus/wwiv/gfiles/, which permits multiple menu configs. i was simplifying to just use gfiles/ directly.
There was a problem hiding this comment.
what do you think the right behavior here is?
There was a problem hiding this comment.
check the current_menu_gfiles_directory() first if the file exists there, then check gfiles directory... i'll rework this.
Fix off-by-one error on choosing a random screen to display
Fixes #1637