fix: make SubscriptionConfiguration work with go 1.20 #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regexp.Regexp implements text marshal/unmarshal only in go 1.21 and newer, requiring some workarounds in previous versions. To support this, implement custom JSON marshalling methods that get compiled only when using go 1.20 and below.
|
We've decided top drop support for go 1.20 instead, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regexp.Regexp implements text marshal/unmarshal only in go 1.21 and
newer, requiring some workarounds in previous versions. To support this,
implement custom JSON marshalling methods that get compiled only when
using go 1.20 and below.