[Fix] variables_default_value_extraction sets type as not nullable when variable is provided #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soonick
force-pushed
the
federation.variable.default.value.ext
branch
from
7150b13 to
b2ead43
Compare
soonick
force-pushed
the
federation.variable.default.value.ext
branch
2 times, most recently
from
445864c to
58f5de2
Compare
…en variable is provided
soonick
force-pushed
the
federation.variable.default.value.ext
branch
from
58f5de2 to
f63fe5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes #640
It seems like
pkg/astnormalization/variables_default_value_extraction.goremoved default values for variables that had a value assigned explicitly, but it wasn't setting the variable as not nullable which resulted in an invalid operation. I believe this should fix it.