New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/planning interfaces with entity implementations #624

Merged

devsergiy merged 45 commits into master from fix/planning-interfaces-with-entity-implementations

Oct 25, 2023

Member

devsergiy commented Sep 29, 2023

No description provided.

devsergiy added 11 commits

September 29, 2023 13:13


          fix planning interface object

4e534b3


          add explicit null to test

978ce82


          fix: representation variables should be nullable objects

988eab2


          chore: move fetch configuration to resolver

7ebfcfb


          embed fetch configuration into SingleFetch

d529873


          rename BatchFetch to EntityBatchFetch

ed1658b

add EntityFetch


          add dissalow single flight to entity fetches

9116c47

add comments to fetch configuration


          take into consideratio disable single flight from fetch

e2eae65


          add create entity fetch in postprocess

8fdde26


          add resolve entity fetch to loader

eee3aec


          always add onType to representation variable

dce2865

do not do an entity request if item is null or empty object

jensneuse reviewed

View reviewed changes

v2/pkg/engine/resolve/load.go Show resolved Hide resolved

jensneuse reviewed

View reviewed changes

v2/pkg/engine/resolve/load.go Show resolved Hide resolved

devsergiy added 12 commits

October 2, 2023 18:31


          chore: fix compilation errors

06565ae


          fix representations variables in federation tests

e5a588c

set entity fetch and batch entity fetch separately


          fix obtaining field type name in addPlannerPathForUnionChildOfObjectP…

43d59bc

…arent

add draft skeleton of rewriting field with interface return type


          add separate selection set rewriter

e58d89b

add more helpers to ast


          add more ast helpers

bf4510e


          add need rewrite rules

6bfabaf


          draft

9df6f08


          cleanup

d0b36fb


          fix ref usage

5f3e6e3


          add helpers to create and update inline fragments

e5e614e


          finish draft

1e9298a


          add initial test

6a824b0

jensneuse reviewed

View reviewed changes

v2/pkg/engine/plan/interface_selection_rewriter.go Show resolved Hide resolved

jensneuse reviewed

View reviewed changes

v2/pkg/engine/plan/interface_selection_rewriter.go Outdated Show resolved Hide resolved

jensneuse reviewed

View reviewed changes

v2/pkg/engine/plan/interface_selection_rewriter.go Outdated Show resolved Hide resolved

jensneuse reviewed

View reviewed changes

v2/pkg/engine/plan/interface_selection_rewriter.go Outdated Show resolved Hide resolved

jensneuse reviewed

View reviewed changes

v2/pkg/engine/plan/interface_selection_rewriter.go Outdated Show resolved Hide resolved

devsergiy added 22 commits

October 12, 2023 14:49


          move helper to ast

eec1d72

replace panics with errors


          fix rewrite during planning

e98e68e


          add more test cases

e35003b


          add more test cases to interface selection rewriter

0bb079c


          fix expanding on a root field

966742b

add expand test case on object for graphql datasource


          add interface expanding on array of interfaces test case for graphql …

c13175b

…datasource


          fix preserving requested __typename

78d1e6b


          add option to enable/disable refs in debug print of operation

1aead8c


          refactor interface rewriter to support unions rewrite

efe9186


          remove on type fragments with types not exists in the current datasource

ba41e08


          Merge remote-tracking branch 'origin/master' into fix/planning-interf…

3588a33

…aces-with-entity-implementations


          fix tests after merge

c1dfd04


          add union & interface test cases

3989b00

add test case for fragment from other datasource


          implement need rewrite check for unions

a8e6771


          implement union selection rewriter

6c8ff13


          fallback to __typename field selection for union when no inline fragm…

b571a1f

…ents were added


          implement fallback to __typename field selection for interface when n…

ad2e00f

…o inline fragments were added


          use upstream schema to get information about interface or union type …

23a1ee3

…members for the datasource


          fix imports

f2da2c5


          fix graphql datasource federation test

fdce7a8


          fix execution test

103ef0a


          fix gosimple linter

3f24929

devsergiy marked this pull request as ready for review

October 25, 2023 09:04

devsergiy merged commit b4e3ab1 into master

6 checks passed

devsergiy deleted the fix/planning-interfaces-with-entity-implementations branch

October 25, 2023 09:08

pvormste added a commit to TykTechnologies/graphql-go-tools that referenced this pull request


          Fix/planning interfaces with entity implementations (wundergraph#624)

2418df5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet