chore: fix local redis tests (#732)

wundergraph · Apr 14, 2024 · 781b00a · 781b00a
1 parent df3dc37
commit 781b00a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.github/workflows/router-ci.yaml b/.github/workflows/router-ci.yaml
@@ -28,6 +28,12 @@ jobs:
       redis:
         # Docker Hub image
         image: redis:7
+        # Set health checks to wait until redis has started
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
         ports:
           - 6379:6379
     steps:
@@ -94,6 +100,12 @@ jobs:
       redis:
         # Docker Hub image
         image: redis:7
+        # Set health checks to wait until redis has started
+        options: >-
+          --health-cmd "redis-cli ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
         credentials:
           username: ${{secrets.DOCKER_USERNAME}}
           password: ${{secrets.DOCKER_PASSWORD}}

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -100,6 +100,7 @@ services:
     ports:
       - '4317:4317' # otlpgrpc
       - '4318:4318' # otlphttp
+      - '8888:8888' # prometheus metrics
     restart: unless-stopped
     depends_on:
       - clickhouse

diff --git a/docker/redis/redis.conf b/docker/redis/redis.conf
@@ -1,5 +1,4 @@
 maxmemory 100mb
 maxmemory-policy noeviction
 save 60 1
-appendonly no
-requirepass test
+appendonly no