fix: update subscription protocol (#517)

wundergraph · Feb 13, 2024 · 5f21022 · 5f21022
1 parent da52139
commit 5f21022
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/cli/src/commands/subgraph/commands/create.ts b/cli/src/commands/subgraph/commands/create.ts
@@ -34,7 +34,7 @@ export default (opts: BaseCommandOptions) => {
   );
   command.option(
     '--subscription-protocol <protocol>',
-    'The protocol to use when subscribing to the subgraph. The supported protocols are ws, sse, and sse-post.',
+    'The protocol to use when subscribing to the subgraph. The supported protocols are ws, sse, and sse_post.',
   );
   command.option('--readme <path-to-readme>', 'The markdown file which describes the subgraph.');
   command.action(async (name, options) => {

diff --git a/cli/src/commands/subgraph/commands/publish.ts b/cli/src/commands/subgraph/commands/publish.ts
@@ -40,7 +40,7 @@ export default (opts: BaseCommandOptions) => {
   );
   command.option(
     '--subscription-protocol <protocol>',
-    'The protocol to use when subscribing to the subgraph. The supported protocols are ws, sse, and sse-post.',
+    'The protocol to use when subscribing to the subgraph. The supported protocols are ws, sse, and sse_post.',
   );
 
   command.action(async (name, options) => {

diff --git a/cli/src/commands/subgraph/commands/update.ts b/cli/src/commands/subgraph/commands/update.ts
@@ -32,7 +32,7 @@ export default (opts: BaseCommandOptions) => {
   );
   command.option(
     '--subscription-protocol <protocol>',
-    'The protocol to use when subscribing to the subgraph. The supported protocols are ws, sse, and sse-post.',
+    'The protocol to use when subscribing to the subgraph. The supported protocols are ws, sse, and sse_post.',
   );
   command.option('--readme <path-to-readme>', 'The markdown file which describes the subgraph.');
 

diff --git a/composition-go/index.global.js b/composition-go/index.global.js
diff --git a/shared/src/router-config/builder.ts b/shared/src/router-config/builder.ts
@@ -33,7 +33,7 @@ export interface Input {
  *
  * ws: Negotiates an appropriate protocol over websockets. Both https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md and https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md are supported
  * sse: Uses the Server-Sent Events protocol with a GET request
- * sse-post: Uses the Server-Sent Events protocol with a POST request
+ * sse_post: Uses the Server-Sent Events protocol with a POST request
  */
 export type SubscriptionProtocol = 'ws' | 'sse' | 'sse_post';
 
@@ -59,15 +59,15 @@ export const internString = (config: EngineConfiguration, str: string): Interned
   });
 };
 
-export const parseGraphQLSubscriptionProtocol = (protocolName: string): GraphQLSubscriptionProtocol => {
+export const parseGraphQLSubscriptionProtocol = (protocolName: SubscriptionProtocol): GraphQLSubscriptionProtocol => {
   switch (protocolName) {
     case 'ws': {
       return GraphQLSubscriptionProtocol.GRAPHQL_SUBSCRIPTION_PROTOCOL_WS;
     }
     case 'sse': {
       return GraphQLSubscriptionProtocol.GRAPHQL_SUBSCRIPTION_PROTOCOL_SSE;
     }
-    case 'sse-post': {
+    case 'sse_post': {
       return GraphQLSubscriptionProtocol.GRAPHQL_SUBSCRIPTION_PROTOCOL_SSE_POST;
     }
   }