Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New template structure #2

Merged
merged 8 commits into from
Apr 26, 2021
Merged

Conversation

fussel178
Copy link
Member

@fussel178 fussel178 commented Apr 22, 2021

Summary

First setup for the new and discussed Telestion application structure.

Details

Updated things:

  • merge Java Apps and PSCs into one repository (see chore: Merge PSC with this repo telestion-rocketsound#1)
  • add test workflow for core app
  • improved Docker publish workflow
    • now uses the new GitHub Container Registry to push Docker images users can use without access to the repo
    • automatic generation from commit messages via Conventional Commits
  • switch to Java 16
  • add some default/nice-to-have configuration files
  • updated READMEs

Intended Release Cycle

When you want to release a new application, go to the Actions Tab in the GitHub UI and choose the Release Action.
Then click Run workflow.

image

This triggers the Release Action which automatically creates a Conventional Commit Release on GitHub.
Afterwards the subsequent build actions are triggered via:

on:
  workflow_run:
    workflows: ["Release"]
    types: [completed]

Additionally, if you want to upload release assets in these build workflows, you can use the cached build environment:

      - name: Restore cache release upload URL ♻️
        uses: actions/cache@v2.1.5
        with:
          path: ~/.build-env
          key: 'github-release-action'

      - name: Import environment
        run: cat ~/.build-env >> $GITHUB_ENV

      - name: Upload release asset
        uses: actions/upload-release-asset@v1.0.1
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        with:
          upload_url: ${{ env.upload_url }}
          asset_path: ./dist/artifact1.txt
          asset_name: artifact1.txt
          asset_content_type: text/plain

You can find more information and an example here:
https://github.com/fussel178/conventional-release-dispatch

Feel free to comment and make improvements on this PR.
I'm open for suggestions. 😉

@fussel178 fussel178 added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 22, 2021
@fussel178 fussel178 self-assigned this Apr 22, 2021
@fussel178 fussel178 changed the title REBASE:feat: New template structure REBASE: feat: New template structure Apr 22, 2021
@fussel178 fussel178 changed the title REBASE: feat: New template structure SQUASH: feat: New template structure Apr 22, 2021
@fussel178 fussel178 changed the title SQUASH: feat: New template structure feat: New template structure Apr 22, 2021
README.md Outdated Show resolved Hide resolved
gui/README.md Outdated Show resolved Hide resolved
Copy link
Member

@jvpichowski jvpichowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gui/telestion-project Outdated Show resolved Hide resolved
core/settings.gradle Outdated Show resolved Hide resolved
core/build.gradle Outdated Show resolved Hide resolved
core/build.gradle Outdated Show resolved Hide resolved
core/build.gradle Outdated Show resolved Hide resolved
core/Dockerfile Outdated Show resolved Hide resolved
@jvpichowski
Copy link
Member

core -> application
gui -> client

fussel178 and others added 2 commits April 26, 2021 13:30
Co-authored-by: pklaschka <contact@pabloklaschka.de>
Co-authored-by: jvpichowski <janvonpichowski@gmail.com>
@fussel178 fussel178 merged commit 9bc1583 into main Apr 26, 2021
@fussel178 fussel178 deleted the feat/new-template-structure branch April 26, 2021 11:45
@fussel178
Copy link
Member Author

@jvpichowski and @pklaschka Thank you very much for your contributions! 🍹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants