[Choreo] Removal of unused internal service resource path named retrieve-api-artifacts and its usage #3639
Conversation
…rtifacts and its usage
| } else { | ||
| adapter.GetAPIs(c, nil, envs, sync.APIArtifactEndpoint, true, apiUUIDList, queryParamMap) | ||
| } | ||
| } else if conf.ControlPlane.DynamicEnvironments.Enabled { |
There was a problem hiding this comment.
We no longer need Dynamic Environments Enabled flag too.
There was a problem hiding this comment.
Config is used in multiple places. Since the issue -> https://github.com/wso2-enterprise/choreo/issues/31875
Is bit urgent shall we track removal of it with another task ?
There was a problem hiding this comment.
If we remove the code, wont the config get ignored or throw an error?
There was a problem hiding this comment.
You mean the cp-overlay config right ?
I'll not throw an error. But we'll have to clean up the repos if we remove the config.
There was a problem hiding this comment.
If we remove the code, wont the config get ignored or throw an error?
Ignored.
Since it is always TRUE (feature flag) we can think it's boolean true and remove unnecessary if blocks.
|
|
[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20250213.5 |
|
[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20250213.5 |
|
[] : dev-deployment-v2 : 20250213.5 |
|
[succeeded] Controlplane cluster : stage-deployment-v2 : 20250214.1 |
|
[succeeded] Dataplane(NorthEU) cluster : stage-deployment-v2 : 20250214.1 |
|
[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20250214.1 |
|
[succeeded] Dataplane(EastUS) cluster : stage-deployment-v2 : 20250214.2 |
|
[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20250214.2 |
|
[succeeded] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20250214.2 |
|
[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20250214.2 |
|
[succeeded] Controlplane cluster : prod-deployment-v2 : 20250214.2 |
Purpose
$subject
Relates with: https://github.com/wso2-enterprise/choreo/issues/31875
Issues
Fixes #
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge