Fix self registration with SelfRegistration.ShowUsernameUnavailability config #7596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7596 +/- ##
=======================================
Coverage 41.85% 41.85%
=======================================
Files 42 42
Lines 939 939
Branches 238 238
=======================================
Hits 393 393
+ Misses 546 502 -44
- Partials 0 44 +44
Flags with carried forward coverage won't be shown. Click here to find out more. |
| if (isAccountVerificationEnabled && !isShowUsernameUnavailabilityEnabled) { | ||
| request.setAttribute("callback", callback); | ||
| if (StringUtils.isNotBlank(srtenantDomain)) { | ||
| request.setAttribute("srtenantDomain", srtenantDomain); |
There was a problem hiding this comment.
what does sr prefix mean in the param name?
pavinduLakshan
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In the self registration flow, SelfRegistration.ShowUsernameUnavailability config was not honoured previously. This PR fixes it.
Related Issues
Related PRs
Checklist
Security checks