Fix callback url resolving logic for api based authn #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR builder started |
...java/org/wso2/carbon/identity/application/authenticator/oidc/OpenIDConnectAuthenticator.java
Outdated
Show resolved
Hide resolved
|
PR builder completed |
|
PR builder started |
janakamarasena
previously approved these changes
May 6, 2024
|
PR builder completed |
ImalshaG
force-pushed
the
api-based-callback
branch
from
b0890c7 to
e100db6
Compare
|
PR builder started |
janakamarasena
approved these changes
May 6, 2024
|
PR builder completed |
jenkins-is-staging
approved these changes
May 6, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/8967986919
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the callback URL resolving logic so that in api based authentication flow the redirect url will be set as the callback url instead of the callback url set in connector properties.
Related issue - wso2/product-is#20173