Improve the callback url resolving logic for api based authn #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
component/src/main/java/org/wso2/carbon/identity/authenticator/github/GithubAuthenticator.java
Show resolved
Hide resolved
janakamarasena
approved these changes
May 6, 2024
|
PR builder started |
|
PR builder completed |
|
The PR builder is not supported for this repo and the integration tests have passed locally. Therefore merging this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the overloaded
getCallbackUrlmethod which loads the redirect url from the authentication context and set it as the callback url instead of taking it from connector properties.Related issue - wso2/product-is#20173
Merge after - wso2-extensions/identity-outbound-auth-oidc#183
Note - Needed to change the access modifier of getApplicationDetails method since it has been changed in the latest identity.outbound.auth.oidc version.