-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLAG-1226] Support grouped legend in doughnut charts #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73e5e5b
to
72e5e3a
Compare
wri7tno
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
72e5e3a
to
874379d
Compare
Merged
willian-viana
added a commit
that referenced
this pull request
Jan 15, 2025
Revert "Merge pull request #4910 from wri/feat/grouped-legend-FLAG-1226"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Support adding groups of legend items in doughnut charts. A legend item is composed of (1) a color swatch, (2) a label, and (3) a statistic.
Acceptance criteria
Groups stack vertically (i.e. flex-direction: column)
Items within a group wrap to form multiple rows if their total width exceeds the parent container (i.e. flex-wrap: wrap)
Groups can have an optional header with the following styles (anything not listed here should be the default for GFW’s typical style):
font-size: 14px
font-weight: bold
There should be a 5px gap between the optional header and the items in the group. This can be achieved though padding, margin, or any other styling that is convenient.
When the widget is shown in full width (e.g. on the dashboard), then the legend should appear to the left of the doughnut. (This is the current behavior).
When the widget is shown in smaller width (e.g. on the analysis panel on the map), then the legend should appear below the doughnut
Sample data for a country
Possible values for drivers_type:
Drivers of non-permanent loss
Drivers of permanent deforestation
Demo