Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLAG-982] Weekly Fire Alerts wrong date comparison #4735

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

willian-viana
Copy link
Collaborator

@willian-viana willian-viana commented Dec 26, 2023

Overview

When doing a year comparison for the weekly fire alerts widget, the selected year or the blue line shows a previous year. For example, 2022 was selected, but 2021 is shown instead. We must ensure that Dec 2022-Dec 2022 is displayed when 2022 is selected. I’m noticing the same pattern for all selected years.

Acceptance criteria:

  • Check whether the data or just the label is incorrect
  • Implement a fix so that the blue label shows a full year (in the example below, should be Dec 2021 - Dec 2022)

Demo

Screenshot 2023-12-28 at 15 32 39

Testing

  • Open the widget
  • Select the year to compare
  • Validate which year appears at year label

@willian-viana willian-viana self-assigned this Dec 26, 2023
@willian-viana willian-viana marked this pull request as ready for review December 28, 2023 18:34
@willian-viana willian-viana force-pushed the fix/weekly-fire-alerts-flag-982 branch from 9ad87f8 to b224796 Compare January 25, 2024 14:03
@willian-viana willian-viana temporarily deployed to gfw-staging-pr-4735 January 25, 2024 14:03 Inactive
@willian-viana willian-viana merged commit f22f111 into develop Jan 29, 2024
4 checks passed
@willian-viana willian-viana deleted the fix/weekly-fire-alerts-flag-982 branch January 29, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants