Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: other(except mui) icon library's icon is not display in UI #439

Open
PritamBag opened this issue Feb 12, 2025 · 0 comments · May be fixed by #440
Open

bugfix: other(except mui) icon library's icon is not display in UI #439

PritamBag opened this issue Feb 12, 2025 · 0 comments · May be fixed by #440
Assignees
Labels
bug Something isn't working

Comments

@PritamBag
Copy link
Member

Describe the bug
In CoreIcon, icons from other icon libraries (except MUI) are not displayed. When attempting to use icons from libraries like FontAwesome they do not render properly, while MUI icons work as expected. Also, Overflow unset usage causes other issues, I think it should be removed as its use is unnecessary.

To Reproduce
Steps to reproduce the behaviour:

  1. Use CoreIcon component with type={__IconTypes.FONTAWESOME_V5_SOLID_ICON} like that
  2. Render the page
  3. See error

Expected behaviour
Those icons should be display as like mui icons.

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version Version 133.0.6943.60 (Official Build) (64-bit)
@PritamBag PritamBag added the bug Something isn't working label Feb 12, 2025
@PritamBag PritamBag self-assigned this Feb 12, 2025
PritamBag added a commit that referenced this issue Feb 12, 2025
fix overflow of coreicon

Ref #439
@PritamBag PritamBag linked a pull request Feb 12, 2025 that will close this issue
8 tasks
@PritamBag PritamBag linked a pull request Feb 12, 2025 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant