Fix JArrayRef DirectBuffer destructor.

Previously it would try to release array elements even if the DirectBuffer constructor was used.
wpilibsuite · Dec 15, 2016 · 9939527 · 9939527
1 parent ce76115
commit 9939527
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/wpiutil/include/support/jni_util.h b/wpiutil/include/support/jni_util.h
@@ -167,7 +167,7 @@ class JArrayRefBase : public JArrayRefInner<JArrayRefBase<T>, T> {
       m_elements = env->Get##F##ArrayElements(jarr, nullptr);                 \
     }                                                                         \
     ~J##F##ArrayRef() {                                                       \
-      if (m_elements)                                                         \
+      if (m_jarr && m_elements)                                               \
         m_env->Release##F##ArrayElements(static_cast<T##Array>(m_jarr),       \
                                          m_elements, JNI_ABORT);              \
     }                                                                         \
@@ -181,7 +181,7 @@ class JArrayRefBase : public JArrayRefInner<JArrayRefBase<T>, T> {
           static_cast<T *>(env->GetPrimitiveArrayCritical(jarr, nullptr));    \
     }                                                                         \
     ~CriticalJ##F##ArrayRef() {                                               \
-      if (m_elements)                                                         \
+      if (m_jarr && m_elements)                                               \
         m_env->ReleasePrimitiveArrayCritical(m_jarr, m_elements, JNI_ABORT);  \
     }                                                                         \
   };