-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[datalog] Move DataLogReaderThread from glass to new libdatalog #7641
base: 2027
Are you sure you want to change the base?
Conversation
92897bb
to
d429635
Compare
Try doing If that doesn't work, try |
This reverts commit 79fb5a3. This error will require more invasive changes on another day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix the Gradle build, everything that links to ntcore also needs to have libdatalog added as a dependency as well. Adding a line to the addNtcoreDependency function (and the jni variant) to link to libdatalog is probably the easiest way to do that.
Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
Co-authored-by: Gold856 <117957790+Gold856@users.noreply.github.com>
Currently the major DataLog backend API (reading and writing) is split between wpiutil and glass. In the interest of allowing code that wants to use these APIs to not need to link to glass and declutter wpiutil, all of those APIs are moved to a new library named "libdatalog".