[cmd] Improve isScheduled to be more performant when checking a single command

[oh-yes-0-fps]

No description provided.

[github-actions]

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

[SamCarlberg]

A simple loop over the array would be fine (this also avoids the Set allocation)

public boolean isScheduled(Command... commands) {
  for (var command : commands) {
    if (!m_scheduledCommands.contains(command)) {
      return false;
    }
  }

  return true;
}  

Wrapping in Set.of is useful only if the same command object is passed in more than once, which should be rare or even nonexistent.

Note that a variadic argument will always create a new array, even if no objects are passed in; ie, isScheduled() effectively compiles to isScheduled(new Command[0]), so this approach doesn't prevent array allocations. If you want to avoid array object allocations, overloads for some number of predetermined parameter counts would be necessary.

[calcmogul]

That loop would make it match the C++ version too.

[oh-yes-0-fps]

Is it worth doing the predetermined overloads? multi-command schedule checks are already uncommon

[SamCarlberg]

A single-command overload would probably be fine with varargs as a fallback

[oh-yes-0-fps]

/format

[SamCarlberg]

@oh-yes-0-fps you'll need to update with main to resolve the failing checks