[cmd] Deprecate Command.schedule() #7072
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
|
Usages (such as Trigger) need to be updated |
It's a footgun and syntactic sugar over the CommandScheduler's schedule method. We don't need syntactic sugar for a footgun.
Gold856
force-pushed
the
deprecate-command-schedule
branch
from
80686e6
to
8c8d94d
Compare
wpilibNewCommands/src/test/native/cpp/frc2/command/CommandSendableButtonTest.cpp
Outdated
Show resolved
Hide resolved
…ableButtonTest.cpp Co-authored-by: Starlight220 <53231611+Starlight220@users.noreply.github.com>
Gold856
force-pushed
the
deprecate-command-schedule
branch
from
83cac71
to
dcc9044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a footgun and syntactic sugar over the CommandScheduler's schedule method. We don't need syntactic sugar for a footgun.