[build] CMake: simplify source JAR creation and install #6831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
PeterJohnson
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An
add_source_jarmacro has been added to simplify maintaining source JARs. The old approach has many bugs, and is easily prone to falling out-of-date when new packages are introduced. Instead, the root directories where Java packages are located are given to the macro, and the macro will handle finding all the source files and assigning the right package to them. In addition, the minimum CMake version has been bumped to 3.21 to ensure theRESOURCESparameter is available.