Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] CMake: add some compiler flags from native-utils #6825

Merged
merged 5 commits into from
Jul 13, 2024

Conversation

Gold856
Copy link
Contributor

@Gold856 Gold856 commented Jul 12, 2024

In preparation for CMake building Maven artifacts, a few compiler flags have been copied over from native-utils to make it more similar to how code is built by Gradle.

@Gold856 Gold856 requested review from PeterJohnson and a team as code owners July 12, 2024 05:35
Copy link
Contributor

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@Gold856
Copy link
Contributor Author

Gold856 commented Jul 12, 2024

/format

@Gold856 Gold856 changed the title [build] CMake: unify compiler options and add some flags from native-utils [build] CMake: add some flags from native-utils Jul 12, 2024
@Gold856 Gold856 changed the title [build] CMake: add some flags from native-utils [build] CMake: add some compiler flags from native-utils Jul 12, 2024
@Gold856 Gold856 force-pushed the unify-compiler-options branch 3 times, most recently from 55a88f3 to f60e465 Compare July 12, 2024 08:27
@PeterJohnson PeterJohnson merged commit e00bb2f into wpilibsuite:main Jul 13, 2024
32 of 33 checks passed
@Gold856 Gold856 deleted the unify-compiler-options branch July 13, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants