Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[commands] Remove deprecated C++ method Command.TransferOwnership #6780

Merged
merged 1 commit into from
Jun 29, 2024
Merged

[commands] Remove deprecated C++ method Command.TransferOwnership #6780

merged 1 commit into from
Jun 29, 2024

Conversation

spacey-sooty
Copy link
Contributor

No description provided.

@spacey-sooty spacey-sooty requested a review from a team as a code owner June 28, 2024 13:54
@github-actions GitHub Actions
Copy link
Contributor

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

@spacey-sooty
Copy link
Contributor Author

This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR.

N/A here Python doesn't have the same ownership semantics

@PeterJohnson
Copy link
Member

Needs a RobotBuilder PR to fix C++.

@Starlight220
Copy link
Member

I think the RobotBuilder check might be broken? Java is also failing, and this error is being printed:
https://github.com/wpilibsuite/allwpilib/actions/runs/9713948699/job/26815947458#step:9:53

@spacey-sooty
Copy link
Contributor Author

RobotBuilder shouldn't have been using this anyways its been deprecated since 2023

@sciencewhiz
Copy link
Contributor

The RB failure should be unrelated because it failed both Java and C++ and this only changes C++

@sciencewhiz
Copy link
Contributor

I think the RobotBuilder check might be broken? Java is also failing, and this error is being printed:
https://github.com/wpilibsuite/allwpilib/actions/runs/9713948699/job/26815947458#step:9:53

That message is unrelated.
#6783 should fix the failure

@PeterJohnson PeterJohnson merged commit 8ba9a55 into wpilibsuite:main Jun 29, 2024
30 checks passed
@spacey-sooty spacey-sooty deleted the transferownership branch June 30, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starlight220 Starlight220 Starlight220 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spacey-sooty @PeterJohnson @Starlight220 @sciencewhiz