[commands] Make requirements private #6769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies commands. Please open a corresponding PR in Python Commands and include a link to this PR. |
|
Not required for python |
spacey-sooty
force-pushed
the
makereqprivate
branch
from
a488d08
to
2e47f99
Compare
Starlight220
requested changes
Jun 30, 2024
wpilibNewCommands/src/main/native/include/frc2/command/Command.h
Outdated
Show resolved
Hide resolved
spacey-sooty
force-pushed
the
makereqprivate
branch
from
2e47f99
to
75643f0
Compare
Starlight220
reviewed
Jul 1, 2024
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java
Outdated
Show resolved
Hide resolved
spacey-sooty
force-pushed
the
makereqprivate
branch
2 times, most recently
from
d55042b
to
a1a5d36
Compare
Starlight220
approved these changes
Jul 9, 2024
Starlight220
requested changes
Jul 9, 2024
There was a problem hiding this comment.
This depends on and includes #6304's changes, so blocking for now
|
Needs a rebase and should be good to go |
spacey-sooty
force-pushed
the
makereqprivate
branch
from
a1a5d36
to
bedba9e
Compare
Starlight220
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #6304