[commands] Fix and deprecate TrapezoidProfileCommand #6722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gold856
force-pushed
the
deprecate-trapezoidprofilecommand
branch
3 times, most recently
from
188f4e0
to
45505b2
Compare
...ain/java/edu/wpi/first/wpilibj/examples/drivedistanceoffboard/subsystems/DriveSubsystem.java
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/DriveDistanceOffboard/cpp/subsystems/DriveSubsystem.cpp
Outdated
Show resolved
Hide resolved
Gold856
force-pushed
the
deprecate-trapezoidprofilecommand
branch
from
f858e7f
to
522a335
Compare
calcmogul
requested changes
Jun 16, 2024
wpilibcExamples/src/main/cpp/examples/DriveDistanceOffboard/cpp/subsystems/DriveSubsystem.cpp
Outdated
Show resolved
Hide resolved
...ain/java/edu/wpi/first/wpilibj/examples/drivedistanceoffboard/subsystems/DriveSubsystem.java
Outdated
Show resolved
Hide resolved
|
/format |
Gold856
force-pushed
the
deprecate-trapezoidprofilecommand
branch
from
69283b1
to
5fdbb29
Compare
Gold856
force-pushed
the
deprecate-trapezoidprofilecommand
branch
from
5fdbb29
to
9436008
Compare
Gold856
force-pushed
the
deprecate-trapezoidprofilecommand
branch
2 times, most recently
from
781de45
to
cc163db
Compare
calcmogul
requested changes
Aug 11, 2024
wpilibcExamples/src/main/cpp/examples/DriveDistanceOffboard/cpp/subsystems/DriveSubsystem.cpp
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/DriveDistanceOffboard/cpp/subsystems/DriveSubsystem.cpp
Outdated
Show resolved
Hide resolved
wpilibcExamples/src/main/cpp/examples/DriveDistanceOffboard/cpp/subsystems/DriveSubsystem.cpp
Show resolved
Hide resolved
Gold856
force-pushed
the
deprecate-trapezoidprofilecommand
branch
from
cc163db
to
f8a800a
Compare
Gold856
force-pushed
the
deprecate-trapezoidprofilecommand
branch
from
f8a800a
to
29614f5
Compare
calcmogul
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the ReplaceMe examples
Change the DriveDistanceOffboard example to have two inline commands that use TrapezoidProfile directly, one that resets the encoders and uses a timer, and another that incorporates encoder readings to drive forward a specified distance without losing encoder data.
Resolves #6454.