Add force and torque units to wpiunits #6676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/format |
SamCarlberg
requested changes
May 29, 2024
|
Just out of curiosity. Is it possible to setup some alias for LinearVelocity. I’d like to jump down that rabbit hole but didn’t want to waste my time if it had already been attempted. |
|
/format |
|
/format |
SamCarlberg
requested changes
May 31, 2024
|
Anything I should do with this one? |
SamCarlberg
approved these changes
Jun 12, 2024
SamCarlberg
reviewed
Jun 12, 2024
|
|
||
| /** A unit of force equivalent to 4.448222 {@link #Newtons}. */ | ||
| public static final Mult<Mass, Velocity<Velocity<Distance>>> PoundsForce = | ||
| derive(Newtons).aggregate(4.448222).named("Pounds-Force").symbol("lb.").make(); |
There was a problem hiding this comment.
Fun fact, the units work out such that using derive(Pounds.mult(Gs)) would accomplish the same thing while letting the library handle the unit conversions for you
There was a problem hiding this comment.
So that leaves the big PR I worked on last week. I'm sure it will take some time to sift through if its got any merit.
Closed
|
Superseded by #6958. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Newtons for force and NewtonMeters for torque to the units API.
Also added singular aliases