-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter depth and processed elements' tags #6917
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Closing this PR as it is merged in #6929 which will be merged in LRC branch already |
Description
Fixes #6904
Explain how this code impacts users.
This PR adds two filters:
rocket_lazy_render_content_depth
: returns integer value with default of2
to adjust the depth.rocket_lazy_render_content_processed_tags
: returns array value with default of:To adjust the elements to be processed by this feature.
Type of change
Detailed scenario
As groomed and mentioned above.
Technical description
Documentation
We only added the filters as mentioned above
New dependencies
No
Risks
We shouldn't have any risk here, we just added the filter so the user can change those values, the only think that I can think of, is that the user can break the functionality by returning not valid elements from the tags filter or by decreasing the depth value.
Mandatory Checklist
Code validation
Code style
Additional Checks