Fix Pop15 test for Julia1.9
#187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natema
approved these changes
Apr 13, 2023
| @@ -2,7 +2,7 @@ _inits = Dict{Symbol, Float64}( | |||
| :p1 => 5.3e7, | |||
| :p2 => 2.1e8, | |||
| :p3 => 2.2e8, | |||
| :p4 => 1.4e8, | |||
| :p4 => 1.8e8, | |||
There was a problem hiding this comment.
Checked: page 173, Appendix C of DGFW.
| function historicalrunsolution() | ||
| isdefined(@__MODULE__, :_solution_historicalrun) && return _solution_historicalrun | ||
| global _solution_historicalrun = solve(historicalrun(), (1900, 2100)) | ||
| global _solution_historicalrun = WorldDynamics.solve(historicalrun(), (1900, 2100); solver = Rodas5()) |
There was a problem hiding this comment.
This PR removes the AutoVern9 method on top of Rodas5. Keeping it raises a mass matrix issue, but removing it results in oscillating plots. We're keeping AutoVern9 in all other plots. We keep investigating the issue in #60.
Comment on lines
+13
to
+16
| @variables fpu(t) = inits[:fpu] | ||
| @variables lmf(t) = inits[:lmf] | ||
| @variables cmi(t) = inits[:cmi] | ||
| @variables cdr(t) le(t) hsapc(t) lmhs(t) lmhs1(t) lmhs2(t) lmc(t) lmp(t) |
There was a problem hiding this comment.
Doing this here makes the plots for pop15 work, but the other plots were working already with
@variables cdr(t) le(t) lmf(t) hsapc(t) lmhs(t) lmhs1(t) lmhs2(t) fpu(t) cmi(t) lmc(t) lmp(t)It is unclear why this is the case and we opened issue #188 to investigate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #182