Finalize create and update users API #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 86.64% 86.58% -0.06%
==========================================
Files 29 29
Lines 1198 1193 -5
==========================================
- Hits 1038 1033 -5
Misses 160 160 ☔ View full report in Codecov by Sentry. |
oliverzheng
approved these changes
Dec 1, 2023
Co-authored-by: Oliver Zheng <services+github@oliverzheng.com>
amygdalama
reviewed
Dec 1, 2023
| USER_PATH, | ||
| method=REQUEST_METHOD_POST, | ||
| params=user, | ||
| headers=headers, |
There was a problem hiding this comment.
ooc what was this change (adding empty headers) for? or was it copy/paste?
There was a problem hiding this comment.
This was me moving methods around (so they are in a different order), and the diff just not dealing with that well 🙃
There was a problem hiding this comment.
oooooh yeah i see my bad 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finalizes the create and update users API methods
Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.