Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save for later #544

Open
alexanmtz opened this issue Mar 23, 2020 · 15 comments
Open

Save for later #544

alexanmtz opened this issue Mar 23, 2020 · 15 comments
Assignees
Labels
beginner tasks status of beginner enhancement Fullstack hiring Issues that can help you to solve hiring challenges starter issue for starter developers
Milestone

Comments

@alexanmtz
Copy link
Member

A new option on task page action bar, with "Save for later" label with a save icon. And once it is clicked and saved, it should switch to "Remove from Save for later" with the delete icon. Then when we are on task explorer, it should have a new tab item with the label "Saved for later", with the issues filtered by the saved ones.

We should create a model with a user with many saved issues.

Why

We should be able to collect issues we're interested in and check later.

Level

Beginner

How to reproduce the user scenario

  • Create a user
  • Import an issue
  • We should have a button "Save for later"

Tips

Check our existing models

@alexanmtz alexanmtz added enhancement starter issue for starter developers beginner tasks status of beginner Fullstack hiring Issues that can help you to solve hiring challenges labels Mar 23, 2020
@alexanmtz alexanmtz added this to the v1.7-apollo milestone Mar 23, 2020
@topseySuave
Copy link

Hello @alexanmtz I would like to work on this issue and would appreciate I am assigned to it.

@alexanmtz
Copy link
Member Author

Hello @topseySuave, you're now assigned to work on this issue 👍

@alexanmtz
Copy link
Member Author

Hello @topseySuave , I think you're missing the step in our README to copy .env.example to .env to have the env variables set.

@topseySuave
Copy link

I got it already sorry, thanks.

@topseySuave
Copy link

Hi, Good day @alexanmtz I have currently added the action button on the frontend and working on actually saving a task in the database, but I have this issue where I created a migration file as well as the model after running sequelize migration:create --name saveTask and run npm run migrate I get only this migration

> node migrate.js up

(node:42393) DeprecationWarning: Using the automatically created return value from client.query as an event emitter is deprecated and will be removed in pg@7.0. Please see the upgrade guide at https://node-postgres.com/guides/upgrading
20200323014820-create-plan migrating
========
========

the new migration file 20200403235735-saveTask I have gets ignored, please do you know how I can go about this?

Thanks.

@alexanmtz
Copy link
Member Author

Hello @topseySuave, can you try to run npm run migrate instead?

@Adekoreday
Copy link
Member

Adekoreday commented May 5, 2020

This issue has been fixed in PR #640 once merged
Kindly use the migration update command
@topseySuave

@alexanmtz alexanmtz removed this from the v1.7-apollo milestone Dec 15, 2020
@alexanmtz alexanmtz added this to the v2.0 milestone May 29, 2024
@neeraj542
Copy link

hey! if still not solved, can I work along?

@alexanmtz
Copy link
Member Author

Hey @neeraj542 , you are assigned, feel free to send your PR when is ready, and let us know if you have any questions

@Niharika0104
Copy link

I want to work on this @alexanmtz

@alexanmtz
Copy link
Member Author

Hey @Niharika0104 , feel free to work on this one and send a PR 👌

@alexanmtz alexanmtz assigned Niharika0104 and unassigned neeraj542 Jan 23, 2025
@Niharika0104
Copy link

Image
@alexanmtz just wanted to confirm my understanding.. we need to have save for later button on every issue present in the issues table right ? and if the issue is marked as save for later then it should have "remove from save for later" button and should also have save for later label on that issue
in the labels filter we need to add save for later filter and when we select that label we should see all the issues which has save for later label on it right?

@alexanmtz
Copy link
Member Author

Hey @Niharika0104 , thanks for sending your questions to clarify this.

You don't need to add a save for later on the issues table; you should add it on the single issue page. And yeah, we will have a new tab of the issues saved for later to be filtered on the issue page.

Let me know if you have any more questions or guidance to complete this.

@alexanmtz
Copy link
Member Author

Hey @Niharika0104 , any progress on this?

@Niharika0104
Copy link

@alexanmtz sorry for the delay I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner tasks status of beginner enhancement Fullstack hiring Issues that can help you to solve hiring challenges starter issue for starter developers
Projects
None yet
Development

No branches or pull requests

6 participants
@alexanmtz @topseySuave @Adekoreday @neeraj542 @Niharika0104 and others