Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Connection credentials are not working (4183) #3097

Merged
merged 14 commits into from
Feb 12, 2025

Conversation

stracker-phil
Copy link
Contributor

@stracker-phil stracker-phil commented Feb 12, 2025

Description

Addresses some issues with the manual connection logic:

  • After successful manual connection, the onboarding wizard is instantly completed
  • Fixes incorrect server response which caused an error message after a successful authentication
  • Manual connection can be triggered by pressing Enter inside the ID or Secret field
  • The wizard stays in "busy" state until the manual connection is fully completed

@stracker-phil stracker-phil marked this pull request as ready for review February 12, 2025 15:01
@Dinamiko Dinamiko merged commit 8258c1c into trunk Feb 12, 2025
6 checks passed
@Dinamiko Dinamiko deleted the PCP-4183-manual-connection-credentials-are-not-working branch February 12, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants