-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Connection credentials are not working (4183) #3097
Merged
Dinamiko
merged 14 commits into
trunk
from
PCP-4183-manual-connection-credentials-are-not-working
Feb 12, 2025
Merged
Manual Connection credentials are not working (4183) #3097
Dinamiko
merged 14 commits into
trunk
from
PCP-4183-manual-connection-credentials-are-not-working
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a modified Mutagen ignore-list, the node_modules folder might not sync with the container; this adjustment fixes psalm errors in those events.
This reverts commit 9037fa9.
A redirect happens, and the current page should stay locked preventing users from interacting with the wizard before the refresh is finished.
# Conflicts: # modules/ppcp-settings/resources/js/data/common/hooks.js
Dinamiko
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses some issues with the manual connection logic: