Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping Labels Revamp] Add validations and error handling to Customs form #13465

Draft
wants to merge 15 commits into
base: trunk
Choose a base branch
from

Conversation

ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Feb 4, 2025

Closes: #

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@ThomazFB ThomazFB added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Feb 4, 2025
@ThomazFB ThomazFB added this to the 21.7 milestone Feb 4, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 4, 2025

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 4, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit415034e
Direct Downloadwoocommerce-wear-prototype-build-pr13465-415034e.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Feb 4, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit415034e
Direct Downloadwoocommerce-prototype-build-pr13465-415034e.apk

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.

Project coverage is 37.89%. Comparing base (3f3a643) to head (415034e).
Report is 19 commits behind head on trunk.

Files with missing lines Patch % Lines
...glabels/customs/WooShippingCustomsFormViewModel.kt 76.47% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #13465      +/-   ##
============================================
+ Coverage     37.88%   37.89%   +0.01%     
- Complexity     8956     8961       +5     
============================================
  Files          2050     2050              
  Lines        112105   112132      +27     
  Branches      14173    14180       +7     
============================================
+ Hits          42474    42496      +22     
- Misses        65751    65754       +3     
- Partials       3880     3882       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wpmobilebot wpmobilebot modified the milestones: 21.7, 21.8 Feb 7, 2025
@wpmobilebot
Copy link
Collaborator

Version 21.7 has now entered code-freeze, so the milestone of this PR has been updated to 21.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants