-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android SDK] Edge to edge main activity doesnt handle well 3 button navigation #13460
Merged
kidinov
merged 6 commits into
13270-android-sdk-update-target-sdk-to-35
from
13455-android-sdk-edge-to-edge-main-activity-doesnt-handle-well-3-button-navigation
Feb 11, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4c14735.
…t itself. Ideal solution would be adding paddings where needed in the fragments but it's 23 fragments in there so a bit out of scope for updating target sdk project and should be a separate one
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Version |
samiuelson
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
c052c7b
into
13270-android-sdk-update-target-sdk-to-35
15 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13455
Description
I noticed that as not all fragments in the main activity use bottom navigation, then in the cases when 3 buttons navigation is used, part of the fragment is hidden behind the navigation. The ideal solution would be to adopt all the fragments, but it's out of the scope for the target SDK project
Also, thanks to @atorresveiga, I realized that the main activity doesn't handle the case when a phone in landscape mode with three-button navigation, then the buttons are placed on a side (I beleave that in older versions they were on the bottom)
This PR also addresses that
Testing information
The tests that have been performed
above
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: