Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revert] Update woo.com domain, update feature-requests URL in yeoman generator #136

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

puntope
Copy link
Contributor

@puntope puntope commented Jun 17, 2024

Changes proposed in this Pull Request:

Project: peeuvX-1zs-p2

This PR reverts part of the changes in #88
that replaced woocommerce.com references with woo.com references.

So this PR will put back woocommerce.com as the domain.

Detailed test instructions:

  1. Confirm all changed URLs work.
  2. Verify no woo.com references are left in the repo
  3. Install the generator according to its readme
  4. create a test directory
  5. run yo grow there
  6. Search for woocommerce.com. Check that feature requests link in .github/CONTRIBUTING.md works

Additional details:

Changelog entry

Tweak - Replace woo.com references with woocommerce.com.

@puntope puntope self-assigned this Jun 17, 2024
@puntope puntope marked this pull request as ready for review June 17, 2024 08:37
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! LGTM.

The PR title is a bit ambiguous at first glance due to the verb combination of revert and update, so maybe it could be tweaked.

@puntope puntope changed the title Revert - Update woo.com domain, update feature-requests URL in yeoman generator [Revert] Update woo.com domain, update feature-requests URL in yeoman generator Jun 18, 2024
@puntope puntope merged commit 796d813 into trunk Jun 18, 2024
3 checks passed
@puntope puntope deleted the tweak/revert-woocom-url branch June 18, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants