PHPCS fixes: PHPCompatibility, Generic
#1095
Conversation
|
@barryhughes Stalled. |
|
@barryhughes What's the reason for the hold up here? This brings the files into compliance with your own standards. Why the delay? |
barryhughes
requested review from
a team and
albarin
and removed request for
a team
|
@crstauf I've requested a reviewer. Partly, we're just stretched pretty thin (not your problem, but it's a current reality). Additionally, these are very large changesets, each of which touches pretty much the entire codebase—and there are several of them—which makes review and testing a pretty time-consuming affair. Working class-by-class or system-by-system, rather than by groups of PHPCS rules, would probably have made this easier and faster. We're also keen to close #971, but it also is not a high priority. To be clear, that's not me saying it is unimportant, however it is also true this does not solve a functional problem or active bug. |
Re-open #1093.
See #971.