Add exact argument to check() function in get_mass_properties_with_density() #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add True argument to check() in get_mass_properties_with_density()
andrewjlock
changed the title
|
I'm somewhat hesitant of merging this because it could be a lot slower which is a backwards imcompatible change... but it's a bit of a niche function so I hope it will be allright, but I'm not ruling out a rollback for this change :) Thank you for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the get_mass_properties() method, the get_mass_properties_with_density() method executes a check() which returns a warning due to using the previous approximate method.
This PR adds a True argument to check() in get_mass_properties_with_density() to remove warning.