Second pull request attempt #227
Conversation
Added simple mesh (one triangle) to illustrate the structure of the mesh class. Some of this may belong in the src, but since everyone looks at the readme, I thought it helpful to do a little explanation here.
Missing setuptools installation. Causing AV check to fail.
|
Wow, that's quite a lot of changes. I got to ask though, did you have issues without the Can you explain the purpose of this pull request? I see a nice addition to the readme and a few random changes that could be due to changes in my branch. |
|
Polite request for a reply @JeffreyOI :) |
|
Hi @wolph , sorry I am just seeing your message. :) I initially just set out to make a MWE of creating an stl from scratch. The example in the readme was a bit complicated for me at first. :P I thought that starting with a single triangle was more instructive. What do you think? As for the other changes, they were in response to my branch failing the tox builds. Since it was failing for reasons other than my readme change, the issues must've been preexisting in the main branch. I wasn’t sure if my submission would get taken seriously if it didn’t pass the auto checks, so I went through every thrown error, fixing each along the way. |
|
p.s. have you ever thought about making a library of primitives like cube(), cone(), sphere(), etc.? It wouldn’t be too difficult I would think, and I imagine it could be quite useful for designers. I have mocked up a cube() fn for a project I’m working on (using numpy-stl). Let me know if this is something you would be interested in. |
|
Yeah, nice idea. It's not what this library was designed for initially, but it could make the workings of the library far more obvious. Thank you for all the help! |
|
I've merged your pull request and I'm going to create a new release today. It seems you've inadvertently fixed the issues that numpy 2 caused: #223 Now the tests for numpy 1 are broken, but that's easily fixable by making your changes conditional :) |
No description provided.