Debug tuple print of np.float #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With numpy>=2.0.0, tuple(vectors[0]) returns the type of the number (eg: np.float64()) instead of the number Adding .tolist() to the vector converts the vector to a python list and could be printed. Work also with numpy <2.0.0
This was referenced Sep 19, 2024
Closed
|
I'm testing whether this works in both cases. I can't just drop numpy 1.x any time soon :) Thank you so much for the pull request though! Even if it doesn't work in both cases, I can simply make the test conditional. |
|
Long overdue, but it's merged, thank you so much for your help! |
|
I suppose it's too late now, but there's also the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug #223
With numpy>=2.0.0, tuple(vectors[0]) returns the type of the number (eg: np.float64()) instead of the number.
Adding .tolist() to the vector converts the vector to a python list and could be printed.
Work also with numpy <2.0.0