fix: handle DirectByteBuffers in WolfSSLSession.read() #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconlon
requested changes
Jan 10, 2025
Fix of improper handling of DirectByteBuffers in the JNI layer. Previously, the native read() method would throw an exception when encountering a DirectByteBuffer, breaking the optimization path for single-buffer reads in WolfSSLEngine. This change modifies the JNI implementation to properly handle both array-backed and direct ByteBuffers, maintaining the performance benefits of both buffer types while fixing the test failure. - Added support for DirectByteBuffers using GetDirectBufferAddress - Preserved existing optimization path for array-backed buffers - Maintained proper position updates and error handling for both types - Fixed SSLEngine/Arrays test without compromising performance
gasbytes
force-pushed
the
SSLEngine-patch
branch
from
3e86f23 to
5de02dc
Compare
cconlon
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of improper handling of DirectByteBuffers in the JNI layer. Previously, the native read() method would throw an exception when encountering a DirectByteBuffer, breaking the optimization path for single-buffer reads in WolfSSLEngine.
This change modifies the JNI implementation to properly handle both array-backed and direct ByteBuffers, maintaining the performance benefits of both buffer types while fixing the test failure.