JSSE: adjust variable resets in Input/OutputStream.close(), more SSLSession tests and fixes #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconlon
force-pushed
the
ioStreamNullFix
branch
from
caeb558 to
7a90f5b
Compare
…other thread is blocked in ssl.read/write() on select/poll()
…ead/write() can detect closure
cconlon
force-pushed
the
ioStreamNullFix
branch
from
7a90f5b to
90544bb
Compare
cconlon
force-pushed
the
ioStreamNullFix
branch
from
90544bb to
ed3db7a
Compare
cconlon
changed the title
src/java/com/wolfssl/provider/jsse/WolfSSLImplementSSLSession.java
Outdated
Show resolved
Hide resolved
…connection establishment
cconlon
force-pushed
the
ioStreamNullFix
branch
from
eeaa1c4 to
f164e64
Compare
JacobBarthelmeh
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes to
WolfSSLSocket,WolfSSLImplementSSLSession, and related classes:this.sslandthis.sockettonullinSSLSocketInput/OutputStream.close()methods, in case there is another thread blocked onselect/poll()inInput/OutputStream.read/write(). Otherwise, this could result in aNullPointerException.SSLSocket.getSession()) at various times throughout handshake process (before, after) and calling SSLSession methods. This will help prevent NullPointerExceptions in the future. Fixes are included toWolfSSLSocketbased on the results of this test.