JSSE: Session resumption check for enabled cipher suite and protocol #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and protocol are enabled
cconlon
force-pushed
the
sessionResumeCipherProtocolChecks
branch
from
7746787 to
7231009
Compare
JacobBarthelmeh
requested changes
Aug 7, 2024
JacobBarthelmeh
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts client-side session resumption to verify the original cipher suite and protocol used for the original session are enabled.
If an initial connection to a server is established and saved into the session cache, but the application then adjusts or removes cipher suites with
SSLSocket/SSLEngine.setEnabledCipherSuites()orSSLSocket/SSLEngine.setEnabledProtocols(), if the cipher suite or protocol used in the first connection is no longer enabled we should fall back to full handshake for the second connection.