-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring in support for MAXQ1065 #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anhu
commented
Jan 10, 2025
•
edited
Loading
edited
- support for committing certificate into MAXQ
- use the specified devId that is saved in the slot or session
NOTE: requires wolfpkcs11/port/maxim directory be created and MXQ_API header files be copied in there. This would be done by scripts in the MAXQ10xx SDK. |
SparkiDev
previously requested changes
Jan 13, 2025
dgarske
requested changes
Jan 21, 2025
If approved, don't merge yet. I would like to squash. |
dgarske
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash. Thank you
- support for committing certificate into MAXQ - use the specified devId that is saved in the slot or session NOTE: requires wolfpkcs11/port/maxim directory be created and MXQ_API header files be copied in there.
dgarske
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.