Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add line endings for error messages #36

Merged
merged 1 commit into from
Aug 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/mdio/mdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ int mdio_parse_bus(const char *str, char **bus)
if (*bus)
return 0;

fprintf(stderr, "ERROR: \"%s\" does not match any known MDIO bus", str);
fprintf(stderr, "ERROR: \"%s\" does not match any known MDIO bus\n", str);
return ENODEV;
}

Expand Down Expand Up @@ -284,7 +284,7 @@ int mdio_device_dflt_parse_val(struct mdio_device *dev,
goto err_invalid;

if (!mask) {
fprintf(stderr, "ERROR: Masking of value not allowed");
fprintf(stderr, "ERROR: Masking of value not allowed\n");
return EINVAL;
}

Expand Down Expand Up @@ -361,7 +361,7 @@ int mdio_common_raw_exec(struct mdio_device *dev, int argc, char **argv)
}

if (argv_peek(argc, argv)) {
fprintf(stderr, "ERROR: Unexpected argument");
fprintf(stderr, "ERROR: Unexpected argument\n");
return EINVAL;
}

Expand Down
4 changes: 2 additions & 2 deletions src/mdio/mva.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ static int mva_parse_reg(struct mdio_device *dev, int *argcp, char ***argvp,
str = argv_pop(argcp, argvp);
tok = str ? strtok(str, ":") : NULL;
if (!tok) {
fprintf(stderr, "ERROR: PAGE:REG");
fprintf(stderr, "ERROR: PAGE:REG\n");
return EINVAL;
} else if (!strcmp(tok, "copper") || !strcmp(tok, "cu")) {
page = MVA_PAGE_COPPER;
Expand All @@ -96,7 +96,7 @@ static int mva_parse_reg(struct mdio_device *dev, int *argcp, char ***argvp,

tok = strtok(NULL, ":");
if (!tok) {
fprintf(stderr, "ERROR: Expected REG");
fprintf(stderr, "ERROR: Expected REG\n");
return EINVAL;
}

Expand Down
4 changes: 2 additions & 2 deletions src/mdio/mvls.c
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ static int mvls_parse_reg(struct mdio_device *dev, int *argcp, char ***argvp,
str = argv_pop(argcp, argvp);
tok = str ? strtok(str, ":") : NULL;
if (!tok) {
fprintf(stderr, "ERROR: Expected PORT:REG");
fprintf(stderr, "ERROR: Expected PORT:REG\n");
return EINVAL;
}

Expand All @@ -488,7 +488,7 @@ static int mvls_parse_reg(struct mdio_device *dev, int *argcp, char ***argvp,

tok = strtok(NULL, ":");
if (!tok) {
fprintf(stderr, "ERROR: Expected REG");
fprintf(stderr, "ERROR: Expected REG\n");
return EINVAL;
}

Expand Down
Loading