Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PG-313] - Fix thumbnails loop duplication #1172

Merged
merged 5 commits into from
Nov 30, 2023
Merged

Conversation

noam-heller1
Copy link
Contributor

@noam-heller1 noam-heller1 commented Nov 28, 2023

  • Refactored scrollToThumbnail function to navigate to the right target item
  • adjust the distance to act like the items weren't duplicated
  • ensure correct highlighting

Jira ticket: https://jira.wixpress.com/browse/PG-313

@liatv
Copy link
Contributor

liatv commented Nov 29, 2023

Hi,
Please add a description and a link to the Jira ticket

@noam-heller1 noam-heller1 changed the title fix thumbnails loop duplication and animations [PG-313] - Fix thumbnails loop duplication Nov 29, 2023
@liatv
Copy link
Contributor

liatv commented Nov 29, 2023

Hi,
Also did you check RTL?

@noam-heller1 noam-heller1 merged commit 97d403d into master Nov 30, 2023
@noam-heller1 noam-heller1 deleted the fix-thumbnails-loop branch November 30, 2023 11:51
@liatv liatv restored the fix-thumbnails-loop branch November 30, 2023 14:14
@liatv liatv deleted the fix-thumbnails-loop branch November 30, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants