fix(guides/imports): update Node.js built-ins section #11508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArmandPhilippot
added
the
improve or update documentation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Looks great! We'll review this tomorrow on Talking and Doc'ing... and close another issue! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Updates the
Node.js builtinssection inguides/importsto fix an incorrect example and to improve the wordings:I don't think I was in this (these? 😅 ) T&D or I don't recall... so maybe the idea was to not mention adapters at all? I'm referring to this comment: #7785 (comment)
Note: I'm not a native speaker but I believe
built-in/builtinare the same... I usedbuilt-inbecause it seems to be the syntax used in other pages (I checked with Algolia). Should we update the heading as well?Related issues & labels (optional)
import.meta.url#7785 (I think after a year it's time to close this one 😄 )