fix: Exclude emoji search input when disabling typing in full screen calls (WPB-16133) #18747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calls (WPB-16133)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #18747 +/- ##
==========================================
- Coverage 45.65% 45.64% -0.01%
==========================================
Files 968 968
Lines 27937 27939 +2
Branches 6302 6303 +1
==========================================
- Hits 12754 12753 -1
- Misses 13594 13596 +2
- Partials 1589 1590 +1 |
V-Gira
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in full screen calls we prevent keyboard events to avoid accidentally typing into the input bar and possibly sending a message. this is also preventing the user to type into the new full reactions search in the full screen call which we need to make an exemption.