Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong grammar in German system message [WPB-14795] #18739

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

waseemansar
Copy link
Contributor

@waseemansar waseemansar commented Feb 11, 2025

BugWPB-14795 [Web] Wrong grammar in German System message ("Sie hat die Unterhaltung umbenannt")

Description

Fixes the incorrect grammar in the German system message ("Sie hat die Unterhaltung umbenannt")

Screenshots/Screencast (for UI changes)

Before

issue-WPB-14795

After

fix-WPB-14795

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.74%. Comparing base (9e5bb99) to head (6cd012f).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #18739      +/-   ##
==========================================
- Coverage   45.75%   45.74%   -0.02%     
==========================================
  Files         944      944              
  Lines       27876    27884       +8     
  Branches     6292     6294       +2     
==========================================
  Hits        12756    12756              
- Misses      13530    13537       +7     
- Partials     1590     1591       +1     

@waseemansar waseemansar merged commit e17dc97 into dev Feb 12, 2025
15 checks passed
@waseemansar waseemansar deleted the fix/german-system-message-WPB-14795 branch February 12, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants